Skip to content

Fix detecting java version for JDK 1.8 #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix detecting java version for JDK 1.8 #462

wants to merge 1 commit into from

Conversation

@slawekjaranowski
Copy link
Member

@slawekjaranowski slawekjaranowski commented Nov 10, 2025

No description provided.

@slawekjaranowski slawekjaranowski linked an issue Nov 11, 2025 that may be closed by this pull request
JavacCompiler fails to resolve version with maven toolchains and Jenkins #420
Open
@nxglhez
Copy link

nxglhez commented Nov 12, 2025

As I said in #420, you should probably go from last to first line: you could inject a javac prefix (I don't say these are real use case):

# with java 21
$ JAVA_TOOL_OPTIONS="-Duser.language=en -Dfoobar='"$'\n'"javac 1.8.0_462"$'\n'"'"  javac -version > /dev/null
Picked up JAVA_TOOL_OPTIONS: -Duser.language=en -Dfoobar='
javac 1.8.0_462
'

The code that's responsible for those messages does not escape anything: https://github.com/openjdk/jdk/blob/400a83da893f5fc285a175b63a266de21e93683c/src/hotspot/share/runtime/arguments.cpp#L3160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slachiewicz slachiewicz slachiewicz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JavacCompiler fails to resolve version with maven toolchains and Jenkins

3 participants

@slawekjaranowski @nxglhez @slachiewicz